Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for bundledDependencies #1436

Closed
schmidsi opened this issue Aug 3, 2019 · 2 comments · Fixed by #1438
Closed

Support for bundledDependencies #1436

schmidsi opened this issue Aug 3, 2019 · 2 comments · Fixed by #1438
Labels
enhancement help wanted

Comments

@schmidsi
Copy link
Contributor

schmidsi commented Aug 3, 2019 •
edited

I have some auto-generated code (through https://github.com/prisma/photonjs) that is located in node_modules/@generated/photon.

How can I tell eslint-plugin-import to not throw a import/no-extraneous-dependencies error? The best solution I can think of so far is to put it into the bundledDependencies. But it seems like eslint-plugin-import does not look at these.

Related: prisma/prisma#314
@ljharb
Copy link
Member

ljharb commented Aug 3, 2019

Absolutely things in bundledDependencies should not error; that seems like an (albeit very very rare) omission. A PR adding that support is welcome.

schmidsi added a commit to schmidsi/eslint-plugin-import that referenced this issue Aug 3, 2019
@schmidsi
Add failing test scenario for import-js#1436
34765ab
@schmidsi schmidsi mentioned this issue Aug 3, 2019
Merged
@schmidsi
Copy link
Contributor Author

schmidsi commented Aug 3, 2019

Thanks for the quick answer.

Just started to work on the PR. Comments are welcome. I will try to do more tomorrow.

schmidsi added a commit to schmidsi/eslint-plugin-import that referenced this issue Aug 4, 2019
@schmidsi
Add failing test scenario for import-js#1436
36eea60
schmidsi added a commit to schmidsi/eslint-plugin-import that referenced this issue Aug 4, 2019
@schmidsi
Implement support for bundledDependencies.
b7b28e8 
- Make tests pass.
- Fixes import-js#1436.
schmidsi added a commit to schmidsi/eslint-plugin-import that referenced this issue Aug 8, 2019
@schmidsi
Add failing test scenario for import-js#1436
5447f64
schmidsi added a commit to schmidsi/eslint-plugin-import that referenced this issue Aug 8, 2019
@schmidsi
Implement support for bundledDependencies.
7a03b9e 
- Make tests pass.
- Fixes import-js#1436.
@ljharb ljharb closed this as completed in 5e143b2 Sep 18, 2019
@schmidsi schmidsi mentioned this issue Sep 18, 2019
Closed
@ljharb ljharb mentioned this issue Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for bundledDependencies schmidsi/eslint-plugin-import
2 participants
@ljharb @schmidsi