[no-commonjs] add allowConditionalRequire option #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
commented
Aug 4, 2019
Pessimistress
force-pushed
the
no-commonjs-conditional-require
branch
from
a7c63d9
to
654dc10
Compare
Pessimistress
changed the title
ljharb
reviewed
Aug 5, 2019
|
I have no idea how to add the option without making these changes... Do you mind if I just add it in the same PR? |
I highly doubt if anyone is relying on these warnings. The only breaking change is that |
|
@Pessimistress adding the option in this PR sounds fine to me. |
benmosher
approved these changes
Aug 20, 2019
Pessimistress
changed the title
ljharb
reviewed
Dec 6, 2019
ljharb
approved these changes
Dec 8, 2019
src/rules/no-commonjs.js
Outdated
| } | ||
|
|
||
| function validateScope(scope) { | ||
| if (scope.variableScope.type === 'module') return true |
There was a problem hiding this comment.
Suggested change
| if (scope.variableScope.type === 'module') return true |
now that the other change is done :-)
ljharb
force-pushed
the
no-commonjs-conditional-require
branch
2 times, most recently
from
945ee6d
to
a60e5c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1437
Currently:
if (typeof window !== "undefined") require("x")is reported by defaultif (typeof window !== "undefined") { require("x") }is never reported (scope)typeof window !== "undefined" && require("x")is never reported (conditional require)After this PR, all cases will be treated the same (as conditional requires). A follow up PR will add an option for users to configure whether conditional requires should be reported.