[core]: regex marking packages as internal #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
Librazy
changed the title
Librazy
force-pushed
the
import-regex
branch
from
9b6def1
to
cc2b96a
Compare
Librazy
force-pushed
the
import-regex
branch
from
cc2b96a
to
fc8b389
Compare
|
Yes please, useful for monorepos, what's the plan for this? |
ljharb
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1125
We are developing packages in a monorepo and packages depend on each other so we need to separate our package from external dependency. We used to tslint/ordered-imports which allow custom group by regex pattern.
This PR added a new setting which allowed user to provide a regex pattern and packages that match that pattern will be marked internal.