fix(importType): Accept '@example' as internal #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
ljharb
requested changes
Oct 8, 2019
ljharb
reviewed
Oct 16, 2019
| @@ -96,7 +98,6 @@ describe('importType(name)', function () { | |||
| }) | |||
|
|
|||
| it("should return 'unknown' for any unhandled cases", function() { | |||
| expect(importType('@malformed', context)).to.equal('unknown') | |||
There was a problem hiding this comment.
why does this need to be removed?
There was a problem hiding this comment.
@malformed is not anymore an unhandled case. This is the purpose of this PR to accept @foo pattern.
The test has been replaced by this one.
ljharb
approved these changes
Dec 6, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
Fix #1379
The bug was related to the
internalregex which didn't accept a module with only one word.This is the case in Typescript when you use the tconfig
pathsto accept the import of@myModulein replacement of/src/someFolder/myModule.Thanks for developing this library!