Fix crash due to export * with no-unused-modules #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
ljharb
requested changes
Oct 8, 2019
There was a problem hiding this comment.
Thanks!
To test it, please add some files in https://github.com/benmosher/eslint-plugin-import/tree/master/tests/files that can reproduce the issue.
|
Is this related? #1260 |
|
@soryy708 Don't seems related to me. From my investigation, it seems that common-js compiled files are not properly managed if you do an |
|
@ljharb I added a test :) |
ljharb
reviewed
Nov 29, 2019
|
@Taranys i rebased this, but tests are failing (altho, these tests might be failing on master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1382
After investigating, It comes from this line
https://github.com/benmosher/eslint-plugin-import/blob/5e143b23f3b89096e1b6a268af723f60c1ecb22f/src/ExportMap.js#L316
In my case,
export * from 'redux-starter-kit'is not detected as unambigous and itreturn nullwhich crash no-unused-modulesI didn't find any good way to test it. I'm looking forward for some advices on how I can test this issue :)