Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-duplicates: allow duplicate if one is namespace and other not #1612

Merged
merged 1 commit into from Jan 16, 2020
Merged

no-duplicates: allow duplicate if one is namespace and other not #1612

merged 1 commit into from Jan 16, 2020

Conversation

sveyret
Copy link
Contributor

@sveyret sveyret commented Jan 15, 2020

It is a syntax error to put both namespace and non namespace import on the same line, so allow it.
Fix issue #1538

It is a syntax error to put both namespace and non namespace import on the same line, so allow it.

Fixes #1538
@sveyret
Copy link
Contributor Author

sveyret commented Jan 15, 2020

Note that this is a simple implementation which will not check:

import * as ns from './foo'
import './foo'

I'm currently working on something better…

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.837% when pulling fe5d6ea on sveyret:nsduplicate into b4d5fd3 on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.837% when pulling fe5d6ea on sveyret:nsduplicate into b4d5fd3 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.837% when pulling fe5d6ea on sveyret:nsduplicate into b4d5fd3 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.837% when pulling fe5d6ea on sveyret:nsduplicate into b4d5fd3 on benmosher:master.

@coveralls
Copy link

coveralls commented Jan 15, 2020

Coverage Status

Coverage increased (+0.002%) to 97.837% when pulling f84d457 on sveyret:nsduplicate into 7e71b50 on benmosher:master.

@ljharb ljharb merged commit f84d457 into import-js:master Jan 16, 2020
@SCasarotto
Copy link

SCasarotto commented May 13, 2021

Note that this is a simple implementation which will not check:

import * as ns from './foo'
import './foo'

I'm currently working on something better…

@sveyret Did you ever circle back on this? I am seeing this issue come up with the following:

import firebase from 'firebase/app';
import 'firebase/auth';
import 'firebase/database';

and was trying to figure out if this was a mistake on my side or if I should create an issue.

EDIT: Created an issue so feel free to disregard. #2054

@sveyret
Copy link
Contributor Author

sveyret commented May 14, 2021

I don’t really remember, but I don’t think I did anything since this PR. It means an evolution is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants