Add eslint-plugin-eslint-plugin internally and fix violations #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds [eslint-plugin-eslint-plugin](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin) (a popular plugin for linting eslint plugins), enables relevant rules from it, and fixes violations. The primary changes included are: 1. Adds missing rule schemas ([require-meta-schema](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-schema.md)). Note that `schema: []` is added to enforce when a rule should have no schema. 2. Adds missing rule `type` property to `no-unused-modules` rule ([require-meta-type](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-type.md)). 3. Removes duplicate test cases ([no-identical-tests](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/no-identical-tests.md)).
bmish
force-pushed
the
eslint-plugin-eslint-plugin
branch
from
d87a5c0
to
084a02d
Compare
2 similar comments
bmish
force-pushed
the
eslint-plugin-eslint-plugin
branch
2 times, most recently
from
dd564cb
to
d296ecf
Compare
|
It looks like there are some Node 4 + eslint 2/3 failures due to incompatibility with eslint-plugin-eslint-plugin. As a path forward, I could still fix all the violations without actually adding the new dev dependency on eslint-plugin-eslint-plugin? |
ljharb
requested changes
Jan 25, 2020
bmish
force-pushed
the
eslint-plugin-eslint-plugin
branch
from
d296ecf
to
16ac399
Compare
ljharb
approved these changes
Jan 26, 2020
ljharb
force-pushed
the
eslint-plugin-eslint-plugin
branch
from
16ac399
to
1c7bb29
Compare
ljharb
force-pushed
the
eslint-plugin-eslint-plugin
branch
from
2512b7e
to
2d42464
Compare
This was referenced Jan 26, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds eslint-plugin-eslint-plugin (a popular plugin for linting eslint plugins), enables relevant rules from it, and fixes violations.
The primary changes included are:
1a. Note that
schema: []is added to enforce when a rule should have no schema.1b. Removed the
es6-onlyoption from a test case for thenamedrule since that option was removed a long time ago.typeproperty tono-unused-modulesrule (require-meta-type).