Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable import/named in the TypeScript configuration #1726

Merged
merged 1 commit into from Apr 13, 2020

Conversation

astorije
Copy link
Contributor

As I was linting our projects, I noticed a few violations across them:

import { IconName } from '@fortawesome/free-solid-svg-icons';
import { GetTrackProps } from 'react-compound-slider';
import { SliderItem } from 'react-compound-slider';
import { InjectedIntl } from 'react-intl';

Looking around, it seems the recommendations are to either use import type (I haven't tried) or disabling the rule locally.
I was wondering what this rule brings when used in a TypeScript setup and realized I am not the only one.

Since it makes sense to disable the rule when using TypeScript, and this rule is enabled by the recommended preset, would it be a ridiculous idea to disable it in the typescript preset of this repo, and save consumers the inconvenience of doing it locally?

(I'm sure some of these could also be disabled, but I figured I would ask your opinions on this one first before looking at others)

@coveralls
Copy link

coveralls commented Apr 13, 2020

Coverage Status

Coverage remained the same at 97.804% when pulling 4f1101e on astorije:patch-1 into fe6cea9 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 95.881% when pulling 5b71029 on astorije:patch-1 into fe6cea9 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 95.881% when pulling 5b71029 on astorije:patch-1 into fe6cea9 on benmosher:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@ljharb ljharb merged commit 4f1101e into import-js:master Apr 13, 2020
@astorije astorije deleted the patch-1 branch April 21, 2020 23:08
@astorije
Copy link
Contributor Author

astorije commented Apr 21, 2020

@ljharb, do you have any rough estimate as to when you are planning to release the next version of this plugin? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants