[Tests] no-extraneous-dependencies: add tests for importing types
#1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
taye
force-pushed
the
fix-allow-extranaeous-type-import
branch
from
df1f80f
to
23e9dc9
Compare
|
This seems to be a duplicate of #1820. I'll land that, and rebase this to include the test case. Thanks! |
ljharb
force-pushed
the
fix-allow-extranaeous-type-import
branch
from
23e9dc9
to
6ed7446
Compare
ljharb
approved these changes
Jun 14, 2020
ljharb
changed the title
no-extraneous-dependencies: add tests for importing types
ljharb
force-pushed
the
fix-allow-extranaeous-type-import
branch
from
6ed7446
to
6f5d95a
Compare
|
Thanks! |
This was referenced Mar 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work on this plugin! ❤️
This PR extends
no-extranaeous-dependencies' check for Flow type imports to also work with TypeScript. This should help with #903 (comment).