Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] first's handling of import = require #1963

Merged
merged 1 commit into from Jan 23, 2021
Merged

[Fix] first's handling of import = require #1963

merged 1 commit into from Jan 23, 2021

Conversation

MatthiasKunnen
Copy link
Contributor

The rule now handles TSImportEqualsDeclaration.

This closes #1957.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 95.355% when pulling 277c86f on MatthiasKunnen:issue-1957-first-import-require into 8c1a65d on benmosher:master.

@coveralls
Copy link

coveralls commented Dec 10, 2020 •
edited

Coverage Status

Coverage increased (+0.0009%) to 97.987% when pulling 196d655 on MatthiasKunnen:issue-1957-first-import-require into 6bb8528 on benmosher:master.

@ljharb ljharb force-pushed the issue-1957-first-import-require branch from 277c86f to 196d655 Compare January 23, 2021 15:30
ljharb
ljharb approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks. Rebased.

@ljharb ljharb merged commit 196d655 into import-js:master Jan 23, 2021
@Peeja
Copy link

Peeja commented Jan 24, 2021

How timely, I just hit this! Thank you, @MatthiasKunnen! ✨

@ljharb ljharb mentioned this pull request Jan 26, 2021
Draft
@MatthiasKunnen MatthiasKunnen deleted the issue-1957-first-import-require branch January 31, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[first] doesn't recognize "import = require" imports in TypeScript
4 participants
@MatthiasKunnen @coveralls @Peeja @ljharb