[Fix] no-unresolved: check import()

[aladdin-add]

dynamic import has changed in estree

refs: estree/estree#197

Fixes #2024

[coveralls]

Coverage increased (+0.9%) to 82.398% when pulling 96ed3c7 on aladdin-add:issue2024 into ab82094 on benmosher:master.

[aladdin-add]

Require “Allow Edits” / Require “Allow Edits” (pull_request_target)

I didn't see the option in the page. :-( 

[aladdin-add]

friendly ping @ljharb

[ljharb]

@aladdin-add i'll take a look soon, but merging this is still blocked on #1986.

[ljharb]

As for the "allow edits" failure; that's because you're making a PR from a fork that's not "aladdin-add", it's "hello-weiran", so due to a github bug, that means you'd need to explicitly give me write perms on https://github.com/hello-weiran/eslint-plugin-import so I can force push to the PR branch.

[ljharb]

This might be a duplicate of #2012.

I'll rebase this after landing that, and keep whatever I can.

[aladdin-add]

didn't notice that. seems this one is no longer needed, so it can be closed now.

[aladdin-add]

the "allow edits" seems working after transfering the repo to "aladdin-add" group.

[aladdin-add]

@ljharb ptal~

[ljharb]

@aladdin-add still looks like there's some test failures; can you take a look?

[aladdin-add]

sure, will do!

[aladdin-add]

the strange thing is: I was not able to repro it - it's working on my computer.

maybe it is related to the "Typescript"?

[ljharb]

What npm version are you using to install it? On node 10+, we're using npm 7 latest in CI.

[aladdin-add]

my local env:
node.js v16.1.0
npm: 7.12.1

On node 10+, we're using npm 7 latest in CI.

I don't think so - there was an error when upgrading npm
https://github.com/benmosher/eslint-plugin-import/pull/2026/checks?check_run_id=2573212587#step:3:532

[ljharb]

While that’s concerning, node 15 and 16 would still ship with some version of npm 7. I’ll have to look into that failure separately.

[aladdin-add]

it seems not related to npm. I switched to npm v6.14.13(local env), and the tests was not failing.

[aladdin-add]

it turns out the node.js/npm version is not as expected. (tested on my fork)

[ljharb]

That's a problem that I thought I'd fixed :-/ i'll take a look at it on master.

[ljharb]

Fixed the tests in master, will rebase now.