Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BatchInput instead of Input for nats_jetstream #2510

Open
GeorgeGkinis opened this issue Apr 13, 2024 · 0 comments
Open

Implement BatchInput instead of Input for nats_jetstream #2510

GeorgeGkinis opened this issue Apr 13, 2024 · 0 comments
Labels
inputs Any tasks or issues relating specifically to inputs nats Issues relating to NATS and Jetstream needs investigation It looks as though have all the information needed but investigation is required performance Issues relating to performance

Comments

@GeorgeGkinis
Copy link

I see that nats_jetstream fetches messages with a batch size of 1

Would it not increase performance to implement the BatchInput interface instead of Input when fetching from a NATS Jetstream?
Adding batchSize as a config parameter and setting to 1 would behave the same as the current implementation.
@mihaitodor mihaitodor added inputs Any tasks or issues relating specifically to inputs needs investigation It looks as though have all the information needed but investigation is required performance Issues relating to performance nats Issues relating to NATS and Jetstream labels Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inputs Any tasks or issues relating specifically to inputs nats Issues relating to NATS and Jetstream needs investigation It looks as though have all the information needed but investigation is required performance Issues relating to performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mihaitodor @GeorgeGkinis