Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Implement timeout in amqp_0_9 output #1342

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

sapk
Copy link
Contributor

@sapk sapk commented Jul 25, 2022

A solution to use context is merged in rabbitmq/amqp091-go#96 so we can manage timeout of confirmation now in benthos.

I based myself on benthos aws s3 timeout configuration as an example and set default to unlimited wait (previous logic).

This is not yet heavily tested but I opened the MR since I think it is near finish so if you have any change needed don't hesitate to send them already.

Fix #1299

@sapk sapk changed the title Implement timeout in amqp_0_9 output Draft: Implement timeout in amqp_0_9 output Jul 25, 2022
@sapk
Copy link
Contributor Author

sapk commented Jul 26, 2022

@Jeffail I am wondering if this should keep backward logic and wait indefinitely or define a sane default timeout (few seconds).

@Jeffail Jeffail merged commit a796675 into redpanda-data:main Jul 28, 2022
@Jeffail
Copy link
Collaborator

Jeffail commented Jul 28, 2022

Thanks @sapk, looks like the previous version was the equivalent of context.Background() by default so I'm assuming there's a fallback timeout deeper in the weeds. Otherwise yeah we probably ought to add a sensible default.

@sapk sapk deleted the fix-1299 branch July 28, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amqp_0_9 deadlock waiting ack
2 participants