Allow sqlite max_page_count to be set #2511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pudalangai <subramanivmk@gmail.com>
pudalangai
force-pushed
the
benthos_max_page_count
branch
from
f9e5af8
to
c1798e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting max_page_count pragma for sqlite. This acts similar to
limitin memory buffer. Once set will limit the db size to page_size * max_page_count. While page_size pragma can also be set, it requires a new db or VACUUM to be done, and also the default 4096 is recommended.For ref: https://www.sqlite.org/pragma.html#pragma_max_page_count, https://www.sqlite.org/limits.html
I've thought of adding field similar to
limitin memory buffer that takes in bytes. The conversions of bytes to page_count wont be exact and might be confusing on what value was set, i'e maxPageCount = limit / page_size; unless page_size is also modified. Feedbacks are welcome.