Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3deploy_2.9.0_windows-amd64.zip contains hugo.exe #313

Closed
suzuki-shunsuke opened this issue Oct 12, 2022 · 3 comments
Closed

s3deploy_2.9.0_windows-amd64.zip contains hugo.exe #313

suzuki-shunsuke opened this issue Oct 12, 2022 · 3 comments

Comments

@suzuki-shunsuke
Copy link

Thank you for your great project.

I found the content of s3deploy_2.9.0_windows-amd64.zip looks wrong.

$ zipinfo s3deploy_2.9.0_windows-amd64.zip 
Archive:  s3deploy_2.9.0_windows-amd64.zip
Zip file size: 5325529 bytes, number of entries: 3
-rwx---     2.0 fat  9677312 bl defN 80-000-00 00:00 hugo.exe
-rw----     2.0 fat     8488 bl defN 80-000-00 00:00 README.md
-rw----     2.0 fat     1086 bl defN 80-000-00 00:00 LICENSE
3 files, 9686886 bytes uncompressed, 5325183 bytes compressed:  45.0%

On the other hand, the content of s3deploy_2.8.1_Windows-64bit.zip looks no problem.

$ zipinfo s3deploy_2.8.1_Windows-64bit.zip 
Archive:  s3deploy_2.8.1_Windows-64bit.zip
Zip file size: 3099348 bytes, number of entries: 3
-rw-r--r--  2.0 unx     1086 bX defN 22-Aug-25 06:33 LICENSE
-rw-r--r--  2.0 unx     7616 bX defN 22-Aug-25 06:33 README.md
-rwxr-xr-x  2.0 unx  9157120 bX defN 22-Aug-25 06:36 s3deploy.exe
3 files, 9165822 bytes uncompressed, 3098940 bytes compressed:  66.2%

Probably this change is related.

https://github.com/bep/s3deploy/releases/tag/v2.9.0

We have ported the release script to Hugoreleaser. This means that the archive names have changed (standardised), but it also means that you get only one unviversal, notarized MacOS PKG archive.

@bep
Copy link
Owner

bep commented Oct 12, 2022

Sorry about this, I will fix ...

@bep bep closed this as completed in abd240a Oct 12, 2022
@bep
Copy link
Owner

bep commented Oct 12, 2022

The archive that's there now is correct. It's only the name of the binary (copy of paste mistake), so you can also just rename hugo.exe => s3deploy.exe.

@suzuki-shunsuke
Copy link
Author

Thank you for your quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants