Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust lab benchmarks do not use provided profile #327

Closed
owobred opened this issue Apr 8, 2024 · 2 comments · Fixed by #328
Closed

Rust lab benchmarks do not use provided profile #327

owobred opened this issue Apr 8, 2024 · 2 comments · Fixed by #328
Labels
bug Something isn't working

Comments

@owobred
Copy link
Contributor

owobred commented Apr 8, 2024

Describe the bug
When running the rust benchmarks in /Laboratory/Rust/benchmarking, the bench profile is ignored. This means that neither the LTO nor the codegen-units used when building.

To Reproduce

  1. Go to /Laboratory/Rust/benchmarking
  2. Run cargo bench
  3. See warning at top of output

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots / Snippets

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /home/bred/scratch/bebop/Laboratory/Rust/benchmarking/Cargo.toml
workspace: /home/bred/scratch/bebop/Laboratory/Rust/Cargo.toml

Info
Tested on 03502a9 using Ubuntu 23.10 on wsl2.
dotnet 8.0.103, rustc 1.79.0-nightly (aa1c45908 2024-04-06)

Additional context
This should probably be fixed by moving the [profile.bench] section from /Laboratory/Rust/benchmarking/Cargo.toml to /Laboratory/Rust/Cargo.toml.
This has no real effect on benchmarks, other than making bincode marginally faster when serializing.

@owobred owobred added the bug Something isn't working label Apr 8, 2024
@andrewmd5
Copy link
Contributor

Thanks for reporting this. Would you mind submitting a PR with the necessary changes?

@owobred
Copy link
Contributor Author

owobred commented Apr 9, 2024

PR created #328.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants