Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is your project still maintained? #689

Open
toofff opened this issue Feb 2, 2022 · 9 comments
Open

Is your project still maintained? #689

toofff opened this issue Feb 2, 2022 · 9 comments

Comments

@toofff
Copy link

toofff commented Feb 2, 2022

Hello team,

Already a big thank you for your project, I appreciate it very much!

I would like to know if this repository is still maintained?

For my project I would like to be able to see this functionality in your project.

What can I do to help you and to keep your project up to date?

no bugs, just a question for you ;)

@LeaVerou
Copy link
Collaborator

LeaVerou commented Feb 3, 2022

Hi there,

It is not quite maintained by @bevacqua. I have created a fork that I plan to port into this repo and continue work here now that @bevacqua has added me as a maintainer, but I got swamped with other stuff meanwhile. It is definitely not dead though!

@toofff
Copy link
Author

toofff commented Feb 3, 2022

Good news !!!

Can I do something to help you? Code review, answer issues, help on code, setting up a CI/CD with github action for example?

I have a little time in the evening at the moment, if I can help it will make me very happy and by the way if at the end I can delete my fork from my project, that would be perfect for everyone :)

@LeaVerou
Copy link
Collaborator

LeaVerou commented Feb 3, 2022

Code review of the changes in the fork I linked to would be useful (from older to newer), also checking for regressions. I don't even remember what state it's in as it's been 2 months since I last worked on it, which makes me wary of just porting the changes upstream. An extra pair of eyes would definitely help!

@toofff
Copy link
Author

toofff commented Feb 3, 2022

I'm looking tonight to clone your project (the v2), to test it, see the dependencies if everything is up to date and check your commits.

I will make you a list here of things to do or finish and I will make you pull requests on your project.

It will take some time but it should do it :)

Very happy to finally have a perspective for this project to be maintained again

@toofff
Copy link
Author

toofff commented Feb 6, 2022

Hi @LeaVerou,

For the moment I tested your new branch and it does not work on my local.
I can't find the problem at the moment, because a lot of change in your branch.

So I cherry-pick each of your commits to better understand what you wanted to do and know when the scripts will break.

Could you tell me the intention of this new branch? Do you have a roadmap in mind?

PS: if my English is not perfect, I apologize right away, I use a translator to help me talk with you

@toofff
Copy link
Author

toofff commented Feb 13, 2022

Hi @LeaVerou,

Since your branch was not functional and I had started things on my side, I decided to cherry-pick the most interesting commits from your branch and add them as I went. It allowed me to correct small things along the way.

So here is my working branch which could give an alpha for a version 2.

I still have a lot of work to do but it's progressing well and here is my main roadmap:

  • development
    • upgrade all devDependencies
    • remove all dependencies
    • import all commits of @LeaVerou
    • import all bug-type pull request commits from the Dragula repository
      • display the list of PRs of bugs to be resumed
    • restructure the code
    • fix all linter issues
    • add typescript
  • rewriting of tests
    • replace tape by Jest
    • added testing library
    • add E2E testing with Cypress
    • pass the linter to the tests folder
  • tooling
    • adding a CI with Github Action
      • on Ubuntu
      • on MacOS
      • on WindowsOS
      • add commitLint rules
    • replace JSHint by ESLint
      • add AirBNB rules
      • add hooks with Husky
        • add eslint
        • add prettier
        • add commitLint rules
    • replace browserify & watchify
    • add Renovate
    • add Snyck
  • documentation to review
    • review README.md file
    • review CONTRIBUTING.md file
    • add COdE_OF_CONDUCT.md file
    • replace example by storybook
    • use github page
  • create CD
    • merge modification on Dragula repository
    • connect with npm platform

if I find enough time, I could probably tag a first version at the end of February for the most optimistic, if not during March 😄

@dgrammatiko
Copy link

@LeaVerou I reviewed your repo and did some of the changes @toofff mentioned above with this PR. It would be awesome if you could push the changes in this repo (probably in another branch) and release it as a Beta, so more testing could be done.

@toofff
Copy link
Author

toofff commented Jul 6, 2022

@dgrammatiko

I have another slightly more advanced version that I started making.
I got to the step put everything in typescript. Maybe I could push a PR on my side.

I took over the work of @LeaVerou and the various fixes pending in this repository.

@toofff
Copy link
Author

toofff commented Jan 19, 2023

A small update for you to talk about the progress of a Dragula2 on my side, the year 2022 was not very productive, however this year is much better.

Never having an answer for a real maintenance of the project, I decided to take it over on my side and make a new version. You can see what I intend to do before producing a first release.

One of the important points before a first stable version would be the establishment of a roadmap with the different ideas set out in this repository. If you ever have any ideas on this subject, @LeaVerou or @dgrammatiko, I'm all ears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants