Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider shrinking editions that only add compat to unsupported versions #155

Open
balupton opened this issue Nov 2, 2023 · 0 comments
Open

Comments

@balupton
Copy link
Member

balupton commented Nov 2, 2023

Currently in my upcoming version I've added a shrinkNodeTests which will shrink tests if an unsupported (but still tested) version fails.

However, native-promise-pool supports node v10 due to a single edition:

determining engines for edition [edition-es2022-esm]...
target:      *
passed:      12.22.12, 14.21.3, 16.20.2, 18.18.2, 20.9.0, 21.1.0
.unique:     12.22.12, 14.21.3, 16.20.2, 18.18.2, 20.9.0, 21.1.0
failed:      
.unique:     
range:       12 || 14 || 16 || 18 || 20 || 21
...determined engines for edition [edition-es2022-esm] as [12 || 14 || 16 || 18 || 20 || 21] against [12.22.12, 14.21.3, 16.20.2, 18.18.2, 20.9.0, 21.1.0]
determining engines for edition [edition-es2022]...
target:      *
passed:      12.22.12, 14.21.3, 16.20.2, 18.18.2, 20.9.0, 21.1.0
.unique:     12.22.12, 14.21.3, 16.20.2, 18.18.2, 20.9.0, 21.1.0
failed:      10.24.1
.unique:     10.24.1
range:       12 || 14 || 16 || 18 || 20 || 21
...determined engines for edition [edition-es2022] as [12 || 14 || 16 || 18 || 20 || 21] against [10.24.1, 12.22.12, 14.21.3, 16.20.2, 18.18.2, 20.9.0, 21.1.0]
determining engines for edition [edition-es2021]...
target:      *
passed:      10.24.1, 12.22.12, 14.21.3, 16.20.2, 18.18.2, 20.9.0, 21.1.0
.unique:     10.24.1
failed:      
.unique:     
range:       10 || 12 || 14 || 16 || 18 || 20 || 21
...determined engines for edition [edition-es2021] as [10 || 12 || 14 || 16 || 18 || 20 || 21] against [10.24.1, 12.22.12, 14.21.3, 16.20.2, 18.18.2, 20.9.0, 21.1.0]
The project supports the extra versions: 10, 12, 14, 16
The project's Node.js engine has stayed as >=10

Perhaps there should be a shrinkUnsupportedEditions property to trim edition-es2021, so only care about keeping editions that tackle supported node.js versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant