Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use esm or support esm for typescript modules that still use require #66

Open
balupton opened this issue Jul 22, 2020 · 0 comments

Comments

@balupton
Copy link
Member

balupton commented Jul 22, 2020

also update valid-module to detect this, if it isn't already, or use valid-module for this detection

this can also be detected by actually testing the generated esm editions

package in question is https://github.com/bevry/pluginloader

the other alternative approach would be for pluginloader to use dynamic imports, however I am unsure how that converts to CJS - for plugin loader, this won't work unless there are breaking changes to the API, as dynamic imports require await, however they are occurring inside the constructor, however that is not a big deal and we can adapt

so a bit of exploration here will go far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant