Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bevy_time optionally depend on bevy_reflect #13263

Merged
merged 1 commit into from May 12, 2024

Conversation

juliohq
Copy link
Contributor

@juliohq juliohq commented May 6, 2024

Objective

Fixes #13246.

@cBournhonesque cBournhonesque added the D-Trivial Nice and easy! A great choice to get started with Bevy label May 6, 2024
@@ -20,7 +20,7 @@ bevy_ecs = { path = "../bevy_ecs", version = "0.14.0-dev", features = [
] }
bevy_reflect = { path = "../bevy_reflect", version = "0.14.0-dev", features = [
"bevy",
] }
], optional = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a feature for enabling this dependency? And to control the feature flag for bevy_ecs? Right now it looks like bevy_ecs will always enable bevy_reflect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean something like adding a bevy_reflect feature to the root workspace that will enable another bevy_reflect feature in bevy_internal?

I was wondering why some crates have an optional dependency on bevy_reflect crate while enabling it in their defaults.

I'm new to contributing to bevy.

Copy link
Contributor

@notmd notmd May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this to the cargo file. Assume the feature is called bevy_reflect. However, I think it should be renamed to reflect for short. Nvm, I just check the bevy_ecs, it also called bevy_reflect

[features]
default = ["dep:bevy_reflect"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I've just added it! Though, I noticed bevy_app also uses bevy_reflect by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah It need to be change to default = ["bevy_reflect"] instead. Sorry for the bad suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no problem! I'm changing the feature name right now.

@BD103 BD103 added A-Reflection Runtime information about types A-Time Involves time keeping and reporting C-Enhancement A new feature X-Uncontroversial This work is generally agreed upon labels May 7, 2024
Copy link
Contributor

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, thank you for taking this.

@juliohq juliohq force-pushed the optional-reflect-for-bevy-time branch from db8a58e to 9f72aa5 Compare May 7, 2024 15:32
@james7132 james7132 requested a review from MrGVSV May 12, 2024 20:55
@MrGVSV MrGVSV added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 12, 2024
@mockersf mockersf added this pull request to the merge queue May 12, 2024
Merged via the queue into bevyengine:main with commit de7ff29 May 12, 2024
32 checks passed
@juliohq juliohq deleted the optional-reflect-for-bevy-time branch May 12, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types A-Time Involves time keeping and reporting C-Enhancement A new feature D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bevy_time optionally depend on bevy_reflect
6 participants