New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bevy_time
optionally depend on bevy_reflect
#13263
Make bevy_time
optionally depend on bevy_reflect
#13263
Conversation
@@ -20,7 +20,7 @@ bevy_ecs = { path = "../bevy_ecs", version = "0.14.0-dev", features = [ | |||
] } | |||
bevy_reflect = { path = "../bevy_reflect", version = "0.14.0-dev", features = [ | |||
"bevy", | |||
] } | |||
], optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a feature for enabling this dependency? And to control the feature flag for bevy_ecs
? Right now it looks like bevy_ecs
will always enable bevy_reflect
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean something like adding a bevy_reflect
feature to the root workspace that will enable another bevy_reflect
feature in bevy_internal
?
I was wondering why some crates have an optional dependency on bevy_reflect
crate while enabling it in their defaults.
I'm new to contributing to bevy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add this to the cargo file. Assume the feature is called bevy_reflect
. However, I think it should be renamed to Nvm, I just check the reflect
for short.bevy_ecs
, it also called bevy_reflect
[features]
default = ["dep:bevy_reflect"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I've just added it! Though, I noticed bevy_app
also uses bevy_reflect
by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah It need to be change to default = ["bevy_reflect"]
instead. Sorry for the bad suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, no problem! I'm changing the feature name right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, thank you for taking this.
db8a58e
to
9f72aa5
Compare
Objective
Fixes #13246.