From 94311fc5fbf7056c32f7fb8f2b5e63d997786e4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois?= Date: Thu, 15 Sep 2022 18:47:15 +0200 Subject: [PATCH 1/3] fix no-default-features for bevy_ecs --- crates/bevy_ecs/src/change_detection.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/bevy_ecs/src/change_detection.rs b/crates/bevy_ecs/src/change_detection.rs index 53fb90aa5a0e7..26b82acbb69ec 100644 --- a/crates/bevy_ecs/src/change_detection.rs +++ b/crates/bevy_ecs/src/change_detection.rs @@ -1,7 +1,6 @@ //! Types that detect when their internal data mutate. use crate::{component::ComponentTicks, ptr::PtrMut, system::Resource}; -#[cfg(feature = "bevy_reflect")] use std::ops::{Deref, DerefMut}; /// The (arbitrarily chosen) minimum number of world tick increments between `check_tick` scans. From f7e6cf622d69f681ec56c44481265836be1d1557 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois?= Date: Thu, 15 Sep 2022 18:47:30 +0200 Subject: [PATCH 2/3] add tests on no-default-features on pr merge --- .github/bors.toml | 3 +++ .github/workflows/validation-jobs.yml | 20 ++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/.github/bors.toml b/.github/bors.toml index 0380d3003e1a9..7c237230f15ca 100644 --- a/.github/bors.toml +++ b/.github/bors.toml @@ -14,6 +14,9 @@ status = [ "check-compiles", "build-and-install-on-iOS", "run-examples-on-windows-dx12", + "build-without-default-features (bevy)", + "build-without-default-features (bevy_ecs)", + "build-without-default-features (bevy_reflect)", ] use_squash_merge = true diff --git a/.github/workflows/validation-jobs.yml b/.github/workflows/validation-jobs.yml index b97b669a7af09..b8f20dc33326f 100644 --- a/.github/workflows/validation-jobs.yml +++ b/.github/workflows/validation-jobs.yml @@ -154,3 +154,23 @@ jobs: with: name: screenshots path: .github/start-wasm-example/screenshot-*.png + + build-without-default-features: + strategy: + matrix: + crate: [bevy_ecs, bevy_reflect, bevy] + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: actions-rs/toolchain@v1 + with: + toolchain: stable + override: true + - name: Install alsa and udev + run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev + if: runner.os == 'linux' + - name: Build + run: cargo build -p ${{ matrix.crate }} --no-default-features + env: + CARGO_INCREMENTAL: 0 + RUSTFLAGS: "-C debuginfo=0 -D warnings" From d7e685bd6c50bd6057cb52848e4f87693a0284d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois?= Date: Wed, 19 Oct 2022 21:57:45 +0200 Subject: [PATCH 3/3] remove condition --- .github/workflows/validation-jobs.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/validation-jobs.yml b/.github/workflows/validation-jobs.yml index b8f20dc33326f..482d70b19d1ca 100644 --- a/.github/workflows/validation-jobs.yml +++ b/.github/workflows/validation-jobs.yml @@ -168,7 +168,6 @@ jobs: override: true - name: Install alsa and udev run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev - if: runner.os == 'linux' - name: Build run: cargo build -p ${{ matrix.crate }} --no-default-features env: