Save email before calling the routes #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LucaRed fixed in my fork: joelharkes/laravel-mailbox version 3.0.0 Although email is not stored before as your implementation would not work in combination with a fallback or a catchAll route. (it would not save the email even though it should, it does in previous implementation) |
joelharkes
reviewed
Aug 11, 2022
| @@ -97,10 +103,6 @@ public function callMailboxes(InboundEmail $email) | |||
| $matchedRoutes[] = $this->catchAllRoute; | |||
There was a problem hiding this comment.
matchRoutes is adapted here which could still lead to a storeEmail() in original code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a route throws an Exception, then the email is lost because it won't be saved in the database.
Saving the email before calling the actual route prevents losing messages.
This also fixes #48.