Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV build is broken #614

Open
franziskuskiefer opened this issue Sep 13, 2022 · 3 comments
Open

MSRV build is broken #614

franziskuskiefer opened this issue Sep 13, 2022 · 3 comments

Comments

@franziskuskiefer
Copy link

Running

cargo +nightly update -Z minimal-versions
cargo build

fails with

error[E0433]: failed to resolve: use of undeclared crate or module `syntax`
 --> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/regex-1.5.0/src/literal/mod.rs:9:9
  |
9 |     use syntax::hir::literal::Literals;
  |         ^^^^^^ use of undeclared crate or module `syntax`

This blocks updating criterion in RustCrypto/formats#720.

@elpiel
Copy link

elpiel commented Nov 18, 2022

MSRV should be made > 1.59 based on the latest master branch

error: package async-global-executor v2.3.0 cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.57.0

https://github.com/bheisler/criterion.rs/actions/runs/3028960427/jobs/4874098488

@dhardy
Copy link

dhardy commented Dec 30, 2023

rust-random/rand#1329 is currently blocked on our MSRV (1.60 in rand master branch).

Testing now wants at least 1.70:

error: package `clap_lex v0.6.0` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.60.0

Does Criterion have any particular policy here on the MSRV?

@elpiel
Copy link

elpiel commented Jan 16, 2024

@dhardy you can check - https://github.com/bheisler/criterion.rs#compatibility-policy

I believe msrv policy is less strict mainly because criterion is used primarily in dev-dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants