Don’t use yielded elements in async generator components when props are stale #214
Comments
|
This issue is closely related to #239. |
brainkim
pushed a commit
that referenced
this issue
Oct 31, 2022
Tanking on a refactoring of async generator components, and making the enqueuing behavior work based on the render loop. 1. Stop letting block promises reject. 2. Explicitly disallow fancy iterators which can be both sync/async. 3. Move the async generator components yielding logic OUTSIDE the run()/step()/advance() loop. 4. Enqueue updates to async generator components based on the render loop. The behavior of components will differ based on whether or not we are in the render loop.
brainkim
pushed a commit
that referenced
this issue
Feb 1, 2023
Tanking on a refactoring of async generator components, and making the enqueuing behavior work based on the render loop. 1. Stop letting block promises reject. 2. Explicitly disallow fancy iterators which can be both sync/async. 3. Move the async generator components yielding logic OUTSIDE the run()/step()/advance() loop. 4. Enqueue updates to async generator components based on the render loop. The behavior of components will differ based on whether or not we are in the render loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just tracking an idea I had last night. It’s possible in async generator components for stale props to be rendered, esp if the async generator component is awaiting something in the loop body. It would be nice if we could throw away all these renders until the next time props is read, to ensure we don’t render out of date children.
Should this work for updates + refreshes, or just updates?
The text was updated successfully, but these errors were encountered: