Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E4 code example missing encoding #1

Open
erikkleinnagelvoort opened this issue Feb 25, 2021 · 1 comment
Open

E4 code example missing encoding #1

erikkleinnagelvoort opened this issue Feb 25, 2021 · 1 comment

Comments

@erikkleinnagelvoort
Copy link

I noticed that the code example in E4 (https://github.com/billbuchanan/appliedcrypto/tree/main/unit04_public_key/lab) misses encoding, which breaks the code.

The line without encoding:
ciphertext = rsa.encrypt('Here is my message', bob_pub)

The line with proper encoding:
ciphertext = rsa.encrypt('Here is my message'.encode('utf-8'), bob_pub)

@billbuchanan
Copy link
Owner

Thank you. I have committed a new version of this, with the encode() method to convert the string to a byte array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants