Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example code in the README does not compile #544

Closed
Dentrax opened this issue May 22, 2022 · 5 comments
Closed

Example code in the README does not compile #544

Dentrax opened this issue May 22, 2022 · 5 comments

Comments

@Dentrax
Copy link

Dentrax commented May 22, 2022

I was trying the Example in the README. And I'm getting the following errors:

  • unresolved imports bincode::Decode, bincode::Encode
  • cannot find function standard in module config
  • cannot find function decode_from_slice in crate bincode

I added bincode = "1.3.3" in [dependencies] section.

Any ideas? 🤔

@Dentrax
Copy link
Author

Dentrax commented May 22, 2022

Tested on latest version bincode = "2.0.0-rc.1" is worked! Maybe we should update the README. 🤞

@VictorKoenders
Copy link
Contributor

The README seems up to date for 2.0.0-rc.1, and I don't see a mention of 1.3.3 anywhere. What do you think should be updated in the README?

@Dentrax
Copy link
Author

Dentrax commented May 24, 2022

Oh, i think i saw 1.3.3 version on crates and jump directly into GitHub page and copied the example section in the README. So I thought it's 1.3.3. Closing.

@Dentrax Dentrax closed this as completed May 24, 2022
@havok4u
Copy link

havok4u commented Dec 9, 2023

I see this issue in 1.3.3 and yes using the rc release fixes it, but when will it make it into stable release i.e. 1.3.4? Item was closed may of 2022.

@VictorKoenders
Copy link
Contributor

Tracking issue for the 2.0 release: #674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants