Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Enode for IpAddr and the other like it ( unstable feature ip_in_core ) #647

Open
elpiel opened this issue Jun 10, 2023 · 5 comments
Open

Comments

@elpiel
Copy link
Contributor

elpiel commented Jun 10, 2023

It's still awaiting stabilisation but it would be nice to include this in 2.0 release and track it's progress as an unstable feature.

Tracking issue: rust-lang/rust#108443

@VictorKoenders
Copy link
Contributor

I'm not keen on having a dedicated feature for this. It shouldn't be a breaking change to modify this in a minor version, so once this is stabilized I think we can just patch it in

@elpiel
Copy link
Contributor Author

elpiel commented Jun 15, 2023

Ok, that's fair. My main pain point right now is on no_std. Right now I must create and maintain a separate struct for encoding/decoding IP addresses instead of using bincode's impl.
For no_std with e.g. embassy we're already using nightly so enabling unstable features like this one makes sense.

@VictorKoenders
Copy link
Contributor

As far as I can tell this should be stable in 1.76 next week

@VictorKoenders
Copy link
Contributor

Looks like I was wrong and this will be stable in rust 1.77, which should be released on march 21th

@elpiel
Copy link
Contributor Author

elpiel commented Apr 5, 2024

ip_in_core is stabilised! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants