Feedback: noUnusedImports

[tjmgregory]

Searched the repo but couldn't find anywhere gathering feedback on the noUnusedImports nursery rule - do shout if I'm wrong.

Issue list

• In React projects it removes the import React from 'react' import required at the top of all TSX/JSX files

[ematipico]

You can check the PR: #428

We intentionally kept that because some projects might use an old version of React. Biome doesn't have information about the project yet, so we called to add it as an exception.

[tjmgregory]

Gotcha 👌

The rule is not recommended, did you enable the rule on purpose?

You mean noUnusedImports? Yeh we'd enabled on purpose as since switching to Biome two weeks ago we've littered imports all over the codebase, making dead code detection harder.

Appreciate the React import is legacy, and right path here since React 17 is to stop importing it - will convince the team 👌

[EvHaus]

Apologies. I didn't see this discussion and opened an issue for this here, as I just ran into this as well.

[Conaclos]

@EvHaus This is a legacy React feature. Do you use React 16 or below?

[ematipico]

Maybe we should add a note to the diagnostics, and warn users about that with some link, that should give users proper information

[EvHaus]

I'm on React 16, but I don't think that matters. I think it depends on which tool is running React. Running React 16 inside of Vitest, for example, still requires the import. I can create a repro if it helps.

[Conaclos]

This is now addressed. We added a new option ignoreReact. See #2306.

Note: This option will be released in Biome 1.7