Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated @babel/polyfill #85

Closed
zGrav opened this issue Jun 16, 2019 · 4 comments
Closed

remove deprecated @babel/polyfill #85

zGrav opened this issue Jun 16, 2019 · 4 comments

Comments

@zGrav
Copy link
Member

zGrav commented Jun 16, 2019

https://babeljs.io/docs/en/babel-polyfill

@zGrav zGrav self-assigned this Jun 16, 2019
@zGrav zGrav added dependencies Pull requests that update a dependency file enhancement and removed dependencies Pull requests that update a dependency file labels Jun 16, 2019
@zGrav
Copy link
Member Author

zGrav commented Jun 16, 2019

seems to exist an issue within jest after removing the polyfill hmmm

@zGrav
Copy link
Member Author

zGrav commented Jun 16, 2019

Seems like babel or jest is not doing something right.

With @babel/plugin-transform-runtime doing corejs: 3

console.log client/services/api.test.js:26 Map {}

should be:

Map { 'content-type' => 'application/json' }

@zGrav
Copy link
Member Author

zGrav commented Jun 16, 2019

To be honest, afaik @maddrag0n @thiemok , @babel/plugin-transform-runtime was to reduce codesize right? literally 0 difference with it enabled/disabled... do we still need it in this point in time?

@zGrav
Copy link
Member Author

zGrav commented Jun 16, 2019

So apparently there is a LOT of back and forth due to this change, and the future is unknown.

Will keep an eye on this: babel/babel#10008 and close this issue/PR for now.

@zGrav zGrav closed this as completed Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant