Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in itsdangerous lib causes problems with the PIP library #17

Open
goraniliev opened this issue Nov 15, 2018 · 2 comments

Comments

@goraniliev
Copy link
Contributor

goraniliev commented Nov 15, 2018

There is a breaking change in itsdangnerous 1.1 (released on Oct 26, 2018). Namely, there is no SigningAlgorithm anymore, which is used by bitcoinaverage PIP lib (_base_client.py).

Users can install an older version (itsdangerous==0.24 for instance) and that would fix the problem. However, this needs to be fixed in the library as well.

Cheers!

@KolevDarko
Copy link
Contributor

Hey @goraniliev
Thanks for the update.

@keithritt
Copy link

keithritt commented Mar 15, 2019

This is a simple fix:
I would fork and submit a push request myself, but I don't see a repo for the actual library.
File: bitcoinaverage\clients_base_client.py

Change import statements to:

from itsdangerous import Signer, want_bytes
from itsdangerous.signer import SigningAlgorithm

See Also: pallets/itsdangerous#121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants