Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 (typescript included) #104

Merged
merged 33 commits into from Apr 3, 2019
Merged

v3 (typescript included) #104

merged 33 commits into from Apr 3, 2019

Conversation

d-yokoi
Copy link
Member

@d-yokoi d-yokoi commented Mar 23, 2019 •
edited by junderw

This is initial typescript implementation of bip39.

Edit: By @junderw

  • Typescript implementation
  • Ability to separate wordlists
  • Remove unorm dependency
  • Remove Hex methods
  • Add Async pbkdf2 (default async, offer Sync method too)

junderw
junderw reviewed Mar 24, 2019
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Change the title when you're finished.

src/ts_src/index.js Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
ts_src/index.ts Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@d-yokoi d-yokoi changed the title wip: initial typescript implementation initial typescript implementation Mar 25, 2019
junderw
junderw reviewed Mar 26, 2019
View reviewed changes
ts_src/index.ts Outdated Show resolved Hide resolved
@junderw
Copy link
Member

junderw commented Mar 26, 2019

See also #105

This was referenced Apr 2, 2019
Closed
Closed
Closed
Closed
@junderw junderw changed the title initial typescript implementation v3 (typescript included) Apr 2, 2019
junderw
junderw approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go. @d-yokoi thoughts?

@d-yokoi
Copy link
Member Author

d-yokoi commented Apr 2, 2019

@junderw
Thanks for your great work!
I think we are ready to go.

@junderw junderw merged commit cd6bcdb into master Apr 3, 2019
@d-yokoi d-yokoi deleted the typescript branch April 3, 2019 14:22
wallace678 referenced this pull request Sep 14, 2022
@SebastienGllmt
Mention 2.3.1 breaking change
a8a489c 
This should probably be mentioned in the changelogs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-yokoi @junderw @ccsalway