Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String.prototype.normalize support #106

Closed
zyuhel opened this issue Mar 28, 2019 · 7 comments
Closed

String.prototype.normalize support #106

zyuhel opened this issue Mar 28, 2019 · 7 comments

Comments

@zyuhel
Copy link

zyuhel commented Mar 28, 2019

Doesn't String.prototype.normalize is supported now by most of the browsers?
May be unorm dependency should be removed and polyfills should be set by builders script of projects using this library?

@junderw
Copy link
Member

junderw commented Apr 1, 2019

Do you have any data on browser support?

@xzjcool
Copy link

xzjcool commented Apr 1, 2019

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/normalize seems only android webview not support. the unorm package is too big

@junderw
Copy link
Member

junderw commented Apr 1, 2019

ok, we'll remove it with the typescript major version change coming up

@zyuhel
Copy link
Author

zyuhel commented Apr 1, 2019

Will it be removed for non typescript version as well?

@junderw
Copy link
Member

junderw commented Apr 2, 2019

What do you mean non-typescript version?

Typescript is a superset of NodeJS, so if you don't want to use Typescript, just don't pull it into your app.

This is a breaking change, so a major version bump is required.

Next major version will use typescript also.

@zyuhel
Copy link
Author

zyuhel commented Apr 2, 2019

So if i understand correctly new major version will be rewritten in typescript?

p.s. should i close this issue and pr then?

@junderw
Copy link
Member

junderw commented Apr 2, 2019

#104 has more info. This will be a version bump.

I have removed unorm from it: 91b0efd

@junderw junderw closed this as completed Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants