Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support COMMENT for tasks #152

Merged
merged 12 commits into from
May 30, 2024
Merged

Support COMMENT for tasks #152

merged 12 commits into from
May 30, 2024

Conversation

sunkup
Copy link
Member

@sunkup sunkup commented May 13, 2024 •
edited

Purpose

Support task comments.

Short description

  • Added a comment field to Task.
  • Enabled Task to read the COMMENT property into the comment field
  • Enabled Task to generate the COMMENT property from the comment field
  • DmfsTask: Generates COMMENT data row (probably with language null) from Task.comment field
  • DmfsTask: Processes COMMENT data row and fills Task.comment field from it

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup added the enhancement New feature or request label May 13, 2024
@sunkup sunkup linked an issue May 13, 2024 that may be closed by this pull request
Support COMMENT for tasks #127
Closed
5 tasks
@sunkup sunkup requested a review from rfc2822 May 13, 2024 13:54
@sunkup sunkup self-assigned this May 13, 2024
@sunkup sunkup requested a review from rfc2822 May 16, 2024 16:22
rfc2822
rfc2822 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I now have removed the trim() because the other properties are not trimmed at this position, too. There's some removeBlackStrings() logic in AndroidEvent; maybe it can be refactored at some time. However we should treat all properties the same.

@rfc2822 rfc2822 merged commit 00244a9 into main May 30, 2024
6 checks passed
@rfc2822 rfc2822 deleted the 127-support-comment-for-tasks branch May 30, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@sunkup sunkup

Labels
enhancement New feature or request
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support COMMENT for tasks
2 participants
@sunkup @rfc2822