Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AbortError #1744

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

frederikprijck
Copy link

Purpose

Backport of 553bb5d to v2.

Changes

Exports the AbortError, which is used internally and thrown on a timeout. https://github.com/node-fetch/node-fetch/blob/2.x/src/index.js#L81

Additional information

#792


  • I updated readme
  • I added unit test(s)

@Richienb
Copy link
Member

@node-fetch/core Is updating v2 like this still a thing we can and should do?

@gr2m gr2m changed the title Export AbortError in v2 feat: AbortError May 19, 2023
Copy link
Collaborator

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason not to. As long as it's not a breaking change

@frederikprijck
Copy link
Author

Following up on my open PRs, any plans to merge this? If not, I can close this.

@gr2m
Copy link
Collaborator

gr2m commented Aug 23, 2023

as there was no objection, I'm going to merge it in 👍🏼 Sorry for the delay

@gr2m gr2m merged commit 9b9d458 into node-fetch:2.x Aug 23, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants