Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change "roundness" of QR code parts individually #5

Open
stefan-schweiger opened this issue Oct 11, 2023 · 2 comments
Open

Comments

@stefan-schweiger
Copy link

Hi, first of great work, I looked through the source code and I think this project is really nicely done!

I was wondering if you might be open to extend the functionality of this package a bit to allow additional configurations. For I already have done the changes locally, just wondering if you are interested in such a thing.

My proposal looks like this:

<qr-code
  contents="bitcoincash:?r=https://bitjson.com/example-url"
  module-color="#1c7d43"
  position-ring-color="#13532d"
  position-center-color="#70C559"
  module-roundness="1"
  position-ring-roundness="1"
  position-center-roundness="1"
>
  <img src="assets/bch.svg" slot="icon" />
</qr-code>
image

All roundness settings set to 0.5:

image

All roundness settings set to 0:

image

I would also want to expose the errorCorrectionLevel and typeNumber. My last proposal is that maybe squares is not the best naming anymore with those changes and maybe it should be called raw?

Let me know if you have any interest in those changes then I will create a PR!

@bitjson
Copy link
Owner

bitjson commented Dec 8, 2023

Hey @stefan-schweiger, I'd be happy to accept a PR! Changes will need to maintain backwards-compatibility, but exposing additional attributes would be fine.

@bitjson
Copy link
Owner

bitjson commented Dec 8, 2023

(Related: I'd also love to take a PR upgrading to the latest version of Stencil, since the version in use is so outdated.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants