Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find alternative solution for renameio #806

Open
alvneiayu opened this issue Mar 31, 2022 · 3 comments
Open

Find alternative solution for renameio #806

alvneiayu opened this issue Mar 31, 2022 · 3 comments
Labels
backlog Issues/PRs that will be included in the project roadmap enhancement help wanted Feature requests approved by maintainers that are not included in the project roadmap

Comments

@alvneiayu
Copy link
Collaborator

Which component:

renameio v1.0.1 in kubeseal

Describe the bug

It seems that the renameio doesn't have Windows support in upper versions than 0.1.0. Right now, we have set up the version in 0.1.0 but we need to find a replacement for this library.

To Reproduce

Replace the version 0.1.0 with the version 1.0.1.

Expected behavior
A clear and concise description of what you expected to happen.

@github-actions github-actions bot added the triage Issues/PRs that need to be reviewed label Mar 31, 2022
@alvneiayu alvneiayu added enhancement backlog Issues/PRs that will be included in the project roadmap and removed triage Issues/PRs that need to be reviewed labels Mar 31, 2022
@alvneiayu alvneiayu added this to Inbox in Sealed Secrets via automation Mar 31, 2022
@mkmik
Copy link
Collaborator

mkmik commented Mar 31, 2022

we can start by reaching out to the upstream project and ask if they're open to contributions to get back windows support.

@mkmik
Copy link
Collaborator

mkmik commented Mar 31, 2022

Ah, basically they're saying that's it's impossible on windows.

So let's just not use that library on windows

@mkmik
Copy link
Collaborator

mkmik commented Mar 31, 2022

(by which I mean we should write our own wrapper that uses that library on all platforms except windows, where it just writes to the file non-atomically)

@alemorcuq alemorcuq added the help wanted Feature requests approved by maintainers that are not included in the project roadmap label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues/PRs that will be included in the project roadmap enhancement help wanted Feature requests approved by maintainers that are not included in the project roadmap
Projects
Sealed Secrets
  
Inbox
Development

No branches or pull requests

3 participants