Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/external-dns] Fix boolean flag --pihole-tls-skip-verify #24578

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[bitnami/external-dns] Fix boolean flag --pihole-tls-skip-verify #24578

merged 1 commit into from
Mar 21, 2024
+3 −3

Conversation

migruiz4
Copy link
Member

Description of the change

Fixes flag boolean flag --pihole-tls-skip-verify.

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Sorry, something went wrong.

@migruiz4
[bitnami/external-dns] Fix boolean flag --pihole-tls-skip-verify
Loading
Loading status checks…
8ab9a14 
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Mar 20, 2024
@github-actions github-actions bot requested a review from andresbono March 20, 2024 17:08
@migruiz4 migruiz4 mentioned this pull request Mar 20, 2024
Closed
rafariossaa
rafariossaa approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migruiz4 migruiz4 merged commit 0c13f72 into main Mar 21, 2024
19 checks passed
@migruiz4 migruiz4 deleted the external-dns-pihole-skip-tls branch March 21, 2024 13:43
djjudas21 pushed a commit to djjudas21/bitnami-charts that referenced this pull request Apr 17, 2024
@migruiz4 @djjudas21
[bitnami/external-dns] Fix boolean flag --pihole-tls-skip-verify (bit…
aa6aedc 
…nami#24578)

Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafariossaa rafariossaa

@andresbono andresbono

Assignees

@andresbono andresbono

Labels
bitnami external-dns solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/external-dns] pihole.tlsSkipVerify: true gives an error
4 participants
@migruiz4 @rafariossaa @andresbono @bitnami-bot