Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/wordpress] Appears that "global.storageClass" overrides more specific storageClass settings #24845

Closed
aragilar opened this issue Apr 3, 2024 · 6 comments · May be fixed by #24863
Closed
Assignees
Labels
solved stale 15 days without activity tech-issues The user has a technical issue about an application triage Triage is needed wordpress

Comments

@aragilar
Copy link

aragilar commented Apr 3, 2024

Name and Version

wordpress:21.0.10

What architecture are you using?

amd64

What steps will reproduce the bug?

Setting global.storageClass to a dummy fallback value (e.g. "test-storage-class") overrides the storageClass used in more specific places (e.g. for wordpress, mariadb.primary.persistence.storageClass and persistence.storageClass). I would expect global to act as a fallback, rather than override the values.

Are you using any custom parameters or values?

No response

What is the expected behavior?

I would expect to be able to use a fallback value in global, so as to be able to catch any cases where the default storage class is being used, and direct them to a more appropriate class.

What do you see instead?

My settings of mariadb.primary.persistence.storageClass and persistence.storageClass are ignored, and global.storageClass is used instead.

Additional information

No response

@aragilar aragilar added the tech-issues The user has a technical issue about an application label Apr 3, 2024
@github-actions github-actions bot added the triage Triage is needed label Apr 3, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for reporting. The logic is set here: https://github.com/bitnami/charts/blob/main/bitnami/common/templates/_storage.tpl#L16

Would you like to submit a PR changing the default behavior?

@javsalgar javsalgar changed the title Appears that "global.storageClass" overrides more specific storageClass settings [bitnami/wordpress] Appears that "global.storageClass" overrides more specific storageClass settings Apr 3, 2024
@aragilar
Copy link
Author

aragilar commented Apr 3, 2024

Sure, I can try and come up with one.

aragilar added a commit to aragilar/bitnami-charts that referenced this issue Apr 3, 2024
This fixes bitnami#24845 as we now prefer the more specific option over the
global option, rather than the other way around.
aragilar added a commit to aragilar/bitnami-charts that referenced this issue Apr 3, 2024
This fixes bitnami#24845 as we now prefer the more specific option over the
global option, rather than the other way around.

Signed-off-by: James Tocknell <aragilar@gmail.com>
aragilar added a commit to aragilar/bitnami-charts that referenced this issue Apr 3, 2024
This fixes bitnami#24845 as we now prefer the more specific option over the
global option, rather than the other way around.

Signed-off-by: James Tocknell <aragilar@gmail.com>
@aragilar
Copy link
Author

aragilar commented Apr 3, 2024

#24863 created with the smallest change I think will fix this.

@javsalgar
Copy link
Contributor

Thank you so much for the PR! The team will take a look

Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Apr 20, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved stale 15 days without activity tech-issues The user has a technical issue about an application triage Triage is needed wordpress
Projects
None yet
3 participants