bitnami/external-dns: Templatize Domain Filters/Exclusions #25603
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Blong <seanblong@gmail.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
carrodher
added
verify
Signed-off-by: Andrés Bono <andresbono@vmware.com>
andresbono
approved these changes
May 13, 2024
clarifai-fmarceau
pushed a commit
to clarifai-fmarceau/bitnami-charts
that referenced
this pull request
May 30, 2024
Signed-off-by: Sean Blong <seanblong@gmail.com> Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: Andrés Bono <andresbono@vmware.com> Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Co-authored-by: Andrés Bono <andresbono@vmware.com> Signed-off-by: Francois Marceau <francois.marceau@clarifai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Leverage the helper function,
common.tplvalues.render, for domain filters and exclusions.Benefits
For our particular use case, we're building ephemeral clusters where the cluster name becomes part of the subdomain requirement. We'd like the ability to parameterize the input to make the Helm chart a little easier to use by reducing number of overrides.
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
N/A
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm