You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When reviewing PR for i578 I noticed that the first test would fail sometimes and the count would be 1. Changing wait_frames(10) to wait_frames(15) would result in a count of 15 (sometimes 14). I poked and prodded the code but couldn't get it to act in the expected manner until I changed the awaiter to count frames via _process instead of _physics_process. This is the opposite of what I would expect. I would not expect higher frame counts in _process than _physics_process, it should be the other way around.
This might mean that we should have wait_frames which waits _process frames and wait_physics_frames which waits based on _physics_process.
I just upgraded to macOS Sonoma 14.4.1 (23E224), so maybe that is causing the issue. This should be verified on other OSes.
When reviewing PR for i578 I noticed that the first test would fail sometimes and the count would be 1. Changing
wait_frames(10)
towait_frames(15)
would result in a count of 15 (sometimes 14). I poked and prodded the code but couldn't get it to act in the expected manner until I changed the awaiter to count frames via_process
instead of_physics_process
. This is the opposite of what I would expect. I would not expect higher frame counts in_process
than_physics_process
, it should be the other way around.This might mean that we should have
wait_frames
which waits_process
frames andwait_physics_frames
which waits based on_physics_process
.I just upgraded to macOS Sonoma 14.4.1 (23E224), so maybe that is causing the issue. This should be verified on other OSes.
Here's the code that I was running
The text was updated successfully, but these errors were encountered: