Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] regenerate notifications schemas #964

Open
michael-land opened this issue Sep 15, 2023 · 2 comments
Open

[feature request] regenerate notifications schemas #964

michael-land opened this issue Sep 15, 2023 · 2 comments

Comments

@michael-land
Copy link

michael-land commented Sep 15, 2023 •
edited

B2bAnyOfferChangedNotification schema is missing

B2bAnyOfferChangedNotification.json
@tusbar
Copy link
Member

tusbar commented Sep 17, 2023 •
edited

Hi @michael-land

As it is often the case, the source file is broken, so the type does not generate.

https://github.com/amzn/selling-partner-api-models/blob/806b438ed95dde14ad832119cabce81a2570a3da/schemas/notifications/B2bAnyOfferChangedNotification.json#L148

This should be #/definitions/moneyType.

I’ve opened a PR – amzn/selling-partner-api-models#332, but it’s unlikely that it’ll get any attention.

@michael-land
Copy link
Author

are you ok with patches to correct those errors while waiting for the schema to be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tusbar @michael-land