CHANGELOG.md

@@ -1,3 +1,6 @@
+# 4.2.0
+- Add "ignore" options to "max-nesting-depth" rule (fixes [#25](https://github.com/bjankord/stylelint-config-sass-guidelines/issues/25)) [PR](https://github.com/bjankord/stylelint-config-sass-guidelines/pull/26)
+
 # 4.1.0
 - Update: Bumped up `stylelint-order` to v0.8.0
 - Fix: Border zero rule. Issue [16](https://github.com/bjankord/stylelint-config-sass-guidelines/issues/16)

README.md

@@ -106,7 +106,7 @@ This is a list of the lints turned on in this configuration, and what they do.
 
 * [`indentation`](http://stylelint.io/user-guide/rules/indentation/): Indentation should always be `2` spaces.
 * [`length-zero-no-unit`](http://stylelint.io/user-guide/rules/length-zero-no-unit/): Disallow units for zero lengths.
-* [`max-nesting-depth`](http://stylelint.io/user-guide/rules/max-nesting-depth/): Limit the allowed nesting depth to `1`.
+* [`max-nesting-depth`](http://stylelint.io/user-guide/rules/max-nesting-depth/): Limit the allowed nesting depth to `1`. _Ignore_: Nested at-rules `@media`, `@supports`, and `@include`.
 * [`no-missing-eof-newline`](http://stylelint.io/user-guide/rules/no-missing-eof-newline/): Disallow missing end-of-file newlines in non-empty files.
 
 #### Media Feature

__tests__/nesting-depth.js

@@ -4,32 +4,63 @@ import postcss from "postcss"
 import scssSyntax from "postcss-scss"
 import test from "tape"
 
-const invalidScss = (
-`.one {
+const invalidScss = `
+.one {
   .two {
+    background-color: #c0ffee;
+
+    @media (min-width: 420px) {
+      background-color: #bada55;
+    }
+
+    @include mixin() {
+      background-color: #ba2;
+    }
+
     .three {
       .four {
         color: #f00;
       }
     }
   }
 }
-`)
+`
 
 test("Nesting depth scss", t => {
-  t.plan(4)
+  t.plan(5)
 
   postcss()
-    .use(stylelint({ code: invalidScss, config: config,}))
+    .use(stylelint({ code: invalidScss, config: config }))
     .process(invalidScss, { syntax: scssSyntax })
     .then(checkResult)
     .catch(logError)
 
   function checkResult(result) {
     t.equal(result.warnings().length, 3, "flags 3 warning")
-    t.is(result.warnings()[0].text, "Expected nesting depth to be no more than 1 (max-nesting-depth)", "correct warning text")
-    t.is(result.warnings()[1].text, "Expected nesting depth to be no more than 1 (max-nesting-depth)", "correct warning text")
-    t.is(result.warnings()[2].text, "Expected \".one .two .three .four\" to have no more than 3 compound selectors (selector-max-compound-selectors)", "correct warning text")
+
+    t.is(
+      result.warnings()[0].text,
+      "Expected nesting depth to be no more than 1 (max-nesting-depth)",
+      "correct warning text"
+    )
+
+    t.is(
+      result.warnings()[1].text,
+      "Expected nesting depth to be no more than 1 (max-nesting-depth)",
+      "correct warning text"
+    )
+
+    t.not(
+      result.warnings()[2].node.type,
+      "atrule",
+      "max-depth ignores at-rules"
+    )
+
+    t.is(
+      result.warnings()[2].text,
+      'Expected ".one .two .three .four" to have no more than 3 compound selectors (selector-max-compound-selectors)',
+      "correct warning text"
+    )
   }
 })
 

index.js

@@ -29,7 +29,16 @@ module.exports = {
     "function-url-quotes": "always",
     "indentation": 2,
     "length-zero-no-unit": true,
-    "max-nesting-depth": 1,
+    "max-nesting-depth": [
+      1,
+      {
+        "ignoreAtRules": [
+          "media",
+          "supports",
+          "include"
+        ]
+      }
+    ],
     "media-feature-name-no-vendor-prefix": true,
     "media-feature-parentheses-space-inside": "never",
     "no-missing-end-of-source-newline": true,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "stylelint-config-sass-guidelines",
-  "version": "4.1.0",
+  "version": "4.2.0",
   "description": "Sharable stylelint config based on https://sass-guidelin.es/",
   "keywords": [
     "stylelint",

src/.stylelintrc.json

@@ -29,7 +29,16 @@
     "function-url-quotes": "always",
     "indentation": 2,
     "length-zero-no-unit": true,
-    "max-nesting-depth": 1,
+    "max-nesting-depth": [
+      1,
+      {
+        "ignoreAtRules": [
+          "media",
+          "supports",
+          "include"
+        ]
+      }
+    ],
     "media-feature-name-no-vendor-prefix": true,
     "media-feature-parentheses-space-inside": "never",
     "no-missing-end-of-source-newline": true,