Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability #2288

Open
lexiconwriter opened this issue Apr 1, 2024 · 4 comments
Open

Vulnerability #2288

lexiconwriter opened this issue Apr 1, 2024 · 4 comments
Labels
bug Something isn't working.

Comments

@lexiconwriter
Copy link

What happened?

package.json:

"obsidian-calendar-ui": "^0.3.12",

The Vulnerable module is svelte.
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-25875

The fix came in svelte@3.49.0

https://snyk.io/advisor/npm-package/obsidian-calendar-ui

DQL

No response

JS

No response

Dataview Version

0.5.66

Obsidian Version

1.5.11

OS

Windows

@lexiconwriter lexiconwriter added the bug Something isn't working. label Apr 1, 2024
@jeetsukumaran
Copy link

I've been getting this for a while too in projects where dataview is installed:

image

$ npm audit
# npm audit report

svelte  <3.49.0
Severity: moderate
Svelte vulnerable to XSS when using objects during server-side rendering - https://github.com/advisories/GHSA-wv8q-r932-8hc7
fix available via `npm audit fix --force`
Will install obsidian-dataview@0.4.21, which is a breaking change
node_modules/svelte
  obsidian-calendar-ui  *
  Depends on vulnerable versions of svelte
  node_modules/obsidian-calendar-ui
    obsidian-dataview  >=0.4.22
    Depends on vulnerable versions of obsidian-calendar-ui
    node_modules/obsidian-dataview

3 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Running "npm audit fix --force" breaks the build in ways that I do not yet understand.

Just ignoring the message seems to work :), but it is very confusing for users, especially when following the "fix" instructions makes things break more :)

@AB1908
Copy link
Collaborator

AB1908 commented Apr 6, 2024

I honestly doubt this is something to worry about given that Obsidian and this plugin both run entirely offline. May be worth upgrading deps though.

@GottZ
Copy link
Contributor

GottZ commented Apr 11, 2024

deps need a push. yes. this issue is nothing to worry about tho, since the effected ssr svelte component is not even used in here at all.
this issue is a false-positive non-issue.

still.. to remove that silly message people see, we should definitely push the dep.

@lexiconwriter
Copy link
Author

to remove that silly message people see, we should definitely push the dep

Better it is: https://owasp.org/Top10/A06_2021-Vulnerable_and_Outdated_Components/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

4 participants