Add support for child pseudo classes to parent selector lists #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
reviewed
Nov 10, 2021
| @@ -94,7 +94,10 @@ function escape(str: string) { | |||
| * Interpolate the `&` with style name. | |||
| */ | |||
| function interpolate(selector: string, styleName: string) { | |||
| return selector.replace(/&/g, styleName); | |||
| return styleName | |||
| .split(/, */) | |||
There was a problem hiding this comment.
The issue is it needs a proper parser because it’s valid to have a comma in a CSS selector, I.e. the selector is escaped or part of a content string or some other match. Although unlikely, it should be handled.
There was a problem hiding this comment.
Makes sense. I was afraid of that -- a parser is a whole different kind of lift. Thanks for the reply, I'll give it some more thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's one possible fix for #103. Suggestions or other fixes very welcome. I haven't done heavy testing/benchmarking with this code yet but I wanted to start a discussion here.
Some questions I had:
,as a delimiter -- does that matter?Closes #103