From ed4d5007b46b01cbe32fb7bdbd98ef7f58463f2b Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Tue, 6 Dec 2022 12:55:46 +0100 Subject: [PATCH 1/2] fix: remove "already registered" warning, which triggered too many false positives --- src/registry.ts | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/registry.ts b/src/registry.ts index 4b66e63..174ef68 100644 --- a/src/registry.ts +++ b/src/registry.ts @@ -14,15 +14,6 @@ export class Registry { identifier = this.generateIdentifier(value); } - if (process.env.NODE_ENV !== 'production') { - const alreadyRegistered = this.kv.getByKey(identifier); - if (alreadyRegistered && alreadyRegistered !== value) { - console.debug( - `Ambiguous class "${identifier}", provide a unique identifier.` - ); - } - } - this.kv.set(identifier, value); } From c85803a9ea24e18e4b5a81bae648f54919b12583 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Tue, 6 Dec 2022 13:57:05 +0100 Subject: [PATCH 2/2] remove warn test --- src/registry.test.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/registry.test.ts b/src/registry.test.ts index ec450d2..ac44247 100644 --- a/src/registry.test.ts +++ b/src/registry.test.ts @@ -16,14 +16,6 @@ test('class registry', () => { expect(() => registry.register(Car)).not.toThrow(); - const warnSpy = jest.spyOn(console, 'debug'); - - registry.register(class Car {}); - expect(warnSpy).toHaveBeenCalledTimes(1); - expect(warnSpy.mock.calls[0][0]).toContain( - 'Ambiguous class "Car", provide a unique identifier.' - ); - registry.register(class Car {}, 'car2'); expect(registry.getValue('car2')).not.toBeUndefined();