Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: scripts for running the test suit with makefile need to be upgraded because of native ether feature #209

Closed
2 tasks done
Tracked by #204
0xneves opened this issue Apr 21, 2024 · 2 comments
Closed
2 tasks done
Tracked by #204

refactor: scripts for running the test suit with makefile need to be upgraded because of native ether feature #209

0xneves opened this issue Apr 21, 2024 · 2 comments
Assignees
@blackbeard002
Labels
help wanted Extra attention is needed Hot Task Doubled points in the reward table refactor Requests for change

Comments

@0xneves
Copy link
Member

0xneves commented Apr 21, 2024 •
edited

A lot was changed by #204 PR's. Thus we need to test the Make test called test-suit-runner.

Definition of done:

  • Call make test-suit-runner after launching npx hardhat node to see if the scripts are working correctly.
  • Fix any issue that stops the test suit from running.

Let me know if there are any problems 👍
@0xneves 0xneves mentioned this issue Apr 21, 2024
Closed
8 tasks
@0xneves 0xneves changed the title refactor: scripts for running the test suit with makefile need to be because of native ether feature refactor: scripts for running the test suit with makefile need to be upgraded because of native ether feature Apr 21, 2024
@0xneves 0xneves added help wanted Extra attention is needed Hot Task Doubled points in the reward table refactor Requests for change labels Apr 21, 2024
@blackbeard002
Copy link
Contributor

Hey @0xneves can I take this up??

@blackbeard002
Copy link
Contributor

blackbeard002 commented May 19, 2024 •
edited

Hey @0xneves ran the make test-suite-runner and all the scripts ran successfully.

  • Scripts are working as expected.
  • No issue that's stopping the test suite from running.

Test screenshot-1
one

Test screenshot-2
two

Test screenshot-3
three

This closes the current issue #209

@0xneves 0xneves closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackbeard002 blackbeard002

Labels
help wanted Extra attention is needed Hot Task Doubled points in the reward table refactor Requests for change
Projects
Swaplace
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blackbeard002 @0xneves