Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: CI or Github Actions #37

Open
pingevt opened this issue Aug 17, 2022 · 4 comments
Open

Testing: CI or Github Actions #37

pingevt opened this issue Aug 17, 2022 · 4 comments
Labels
#core documentation Improvements or additions to documentation

Comments

@pingevt
Copy link
Member

pingevt commented Aug 17, 2022

Add testing to Github Actions, so we can see test results for PRs and also not rely on local testing only

@benjaminbojko
Copy link
Collaborator

@pingevt could you add a description for this ticket?

@pingevt
Copy link
Member Author

pingevt commented Aug 25, 2022

If we release this to the public, we may want to add this sooner than later. Bumping priority to medium

  • How to we run tests?
  • List out tests
    • Start with covering the JSON source

@benjaminbojko
Copy link
Collaborator

Sounds good! Do you already have any thoughts on what to test and how? I've been shying away from it just given the number of dependencies and use cases.

@pingevt
Copy link
Member Author

pingevt commented Aug 25, 2022

HA - yea, I've been afraid of that list as well. I haven't really done testing in Node env either.

I think the first step is just "how is this setup"? Can we unit test or do we need full functional testing - or both? And just like the documentation, we make sure we check it off when we submit a PR.

Some of the util classes I could see adding unit tests. But for the most part I think we need functional tests.

From My perspective on the content side, I'd love to have test coverage on all the sources and all the config variables we're using so we can easily see breaking changes. With everything here though, let's start small, and add in as we can.

The JSON source is pretty simple and we can start there as an actual test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#core documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants