Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/Authentication Layer #56

Open
2 tasks
pingevt opened this issue Aug 29, 2022 · 6 comments
Open
2 tasks

User/Authentication Layer #56

pingevt opened this issue Aug 29, 2022 · 6 comments

Comments

@pingevt
Copy link
Member

pingevt commented Aug 29, 2022

For the server we need to implement authentication. So user, passwords and the whole deal. Initially, I have it all implemented in the Server package, BUT do we need users for other things?

Also, created quick cli commands for user creation/editing/deletion. Not sure if this is the best way to handle this.


  • do we need users for other things?
  • How should we handle the admin for creating/editing/deleting users
@benjaminbojko
Copy link
Collaborator

BTW now that I'm reviewing my notes, I think this was one of the reasons I was interested in KOA. It has a pretty wide selection of auth layers that might be worth looking into: https://github.com/koajs/koa/wiki#authentication

LMK what you think!

@pingevt
Copy link
Member Author

pingevt commented Aug 29, 2022

@benjaminbojko - so Express and KOA are completely different, so I don't think we can combine them. I've just been using express cause its what I'm familiar with, but fine going either way. SO we should make that decisions soon. Looks like KOA does allow for web sockets as well. So At this point I think its an either/or.

@benjaminbojko
Copy link
Collaborator

For sure, I didn't think of them living side-by-side. Did you already get far with implementing Express? Maybe doing a quick survey on Slack might be a good idea.

IMO Express just seems heavy handed for what we need and something like Koa seems a little more lightweight and purposefully built for a slim core with extendibility in mind. This article gives a good comparison.

Koa to me seems more nimble and modern (fewer callbacks, better async flows), but I haven't personally tried it. On paper, it sounds like it would make some of the challenges with scalability and customization that we faced with AM/PM + Express easier to deal with.

@pingevt
Copy link
Member Author

pingevt commented Aug 29, 2022

Oh that looks like a better article, i found 2 but they were a bit old.

I can switch it over... It might be good to learn as well. Lets see if anyone says anything in slack.

@pingevt
Copy link
Member Author

pingevt commented Sep 2, 2022

@benjaminbojko - I've been playing with Koa this morning. form the LP architecture side, I think its easy to switch and replace express. At this point, seems like we need to make an executive decision. My thoughts:

  • Internally for BC, we're not experts on either
  • Launch pad is so small, not sure the performance benefits of koa over express mean that much
  • Koa does seem to be a bit future forward
  • Probably good to get some Koa experience

Honestly, I don't know what your challenges were with AM/PM + Express, but koa does seem a bit more modern and future forward.. so, I say let's do it.

@benjaminbojko
Copy link
Collaborator

Agreed! Feels more future proof and why not try something new :) Let's try Koa and keep the architecture as light as possible.

@pingevt pingevt removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants