Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zero length uploads #57

Closed
creadth opened this issue Apr 14, 2024 · 5 comments
Closed

Support zero length uploads #57

creadth opened this issue Apr 14, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@creadth
Copy link

creadth commented Apr 14, 2024

Currently if UploadLength is set to zero without setting IsUploadDeferLength to true, the library will throw an error that "UploadLength should not be less than zero", so it is not possible to upload empty files without adjusting headers with OnPreSendRequestAsync event.

@bluetianx bluetianx self-assigned this Apr 14, 2024
@bluetianx
Copy link
Owner

Why do you want to set UploadLength to zero without setting IsUploadDeferLength? Can you tell me about it?

@creadth
Copy link
Author

creadth commented Apr 14, 2024

When user uploads a file with zero content, BirdMessenger is unable to process this request and fails. tus server and other libs handle this request correctly - uploading an empty file.

@creadth creadth closed this as completed Apr 14, 2024
@creadth creadth reopened this Apr 14, 2024
@bluetianx
Copy link
Owner

ok, I got it , I will deal with it

@bluetianx
Copy link
Owner

@bluetianx bluetianx added the feature feature label Apr 15, 2024
@bluetianx
Copy link
Owner

@creadth , Upgrading BirdMessenger to 3.1.3 , Your problem will be resolved

@bluetianx bluetianx added bug Something isn't working and removed feature feature labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants