Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning as error in CLI mode #38

Closed
dubzzz opened this issue Apr 3, 2023 · 3 comments
Closed

Warning as error in CLI mode #38

dubzzz opened this issue Apr 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dubzzz
Copy link

dubzzz commented Apr 3, 2023

Having the ability to mark warnings as errors when running publint through the CLI might be pretty useful. Some lint rules such as types not being properly defined via exports come as warnings and being able to promote them to errors (not just them, but just say we forbid errors and warnings) would be great.

I was thinking about some flags such as --warning-as-error or --max-warnings num (see https://eslint.org/docs/latest/use/command-line-interface#max-warnings).

@bluwy
Copy link
Owner

bluwy commented Apr 6, 2023

Make sense to me 👍 Maybe a --strict option would be nice too. I should probably re-evaluate what gets to be a warning and error in the next major, they're a bit inconsistent now.

@bluwy bluwy added the enhancement New feature or request label Apr 6, 2023
@bluwy bluwy closed this as completed in 4032625 May 20, 2023
@bluwy
Copy link
Owner

bluwy commented May 20, 2023

The --strict flag is supported in v0.1.12

@dubzzz
Copy link
Author

dubzzz commented May 20, 2023

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants